Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update circuit breaker to allow up to 32,000 rules per minute #190057

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Update circuit breaker to allow up to 32,000 rules per minute #190057

merged 2 commits into from
Aug 9, 2024

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Aug 7, 2024 •
edited
Loading

In this PR, I'm raising the rules-per-minute circuit breaker from 10,000 to 32,000.

Note: Serverless still overwrites the default and sets 400 as the value.

To verify

  1. Download this ES archive and unzip it somewhere on your local machine
    es.zip
  2. Startup Elasticsearch with the given ES archive (yarn es snapshot -E path.data=/path/to/es)
  3. Startup Kibana (yarn start)
  4. Navigate the to rules page and create any alerting rule
  5. Notice the rule gets created successfully
  6. Try adding another rule
  7. Notice the circuit breaker is hit, and you cannot create the alerting rule

@mikecote mikecote added Feature:Alerting Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 7, 2024
@mikecote mikecote mentioned this pull request Aug 7, 2024
Open
48 tasks
@mikecote mikecote changed the title Allow up to 32,000 rules per minute Update circuit breaker to allow up to 32,000 rules per minute Aug 7, 2024
@mikecote
Copy link
Contributor Author

mikecote commented Aug 7, 2024

/ci

@mikecote
Copy link
Contributor Author

mikecote commented Aug 7, 2024

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

mikecote commented Aug 7, 2024

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / useAllEsqlRuleFields should return index pattern fields concatenated with ES|QL fields when ES|QL query is non-aggregating

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote marked this pull request as ready for review August 7, 2024 17:58
@mikecote mikecote requested a review from a team as a code owner August 7, 2024 17:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote mikecote self-assigned this Aug 7, 2024
@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Aug 8, 2024
ersin-erdal
ersin-erdal approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit 539008c into elastic:main Aug 9, 2024
42 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees

@mikecote mikecote

Labels
backport:skip This commit does not require backporting Feature:Alerting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikecote @kibana-ci @elasticmachine @ersin-erdal @kibanamachine